fix: glitching when reordering items#586
Merged
Merged
Conversation
|
Hi @computerjazz, could you please take a look at this one? |
|
+1 |
|
I also experienced this and tried the fork. The fix is working very well. 🙏 |
Owner
|
thanks! |
8 tasks
|
This PR seems to be causing issues for me. I started using 4.0.3, and encountered issues matching the description in #572. Using version 4.0.2 I see no such issues. I'm happy using 4.0.2 for now, just letting you know there's a potential regression here. |
Contributor
Author
|
Have you got new architecture turned on? |
|
Ah, not in that project, no. |
outaTiME
added a commit
to outaTiME/react-native-draggable-flatlist
that referenced
this pull request
Jul 3, 2025
thai99hanoi
added a commit
to thai99hanoi/react-native-draggable-flatlist
that referenced
this pull request
Jul 3, 2025
This reverts commit b780c49.
Danswar
pushed a commit
to BtcTaroWallet/react-native-draggable-flatlist
that referenced
this pull request
Apr 22, 2026
* fix: glitching when reordering items * fix: don't change animation style as that causes glitches
callaars
added a commit
to sunsama/react-native-draggable-flatlist
that referenced
this pull request
May 2, 2026
Track lib/ in this fork since it's consumed via git+SHA, and add lib/ to .prettierignore so the pre-commit hook skips generated output. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue: #572
This PR fixes an issue where drag state (
activeKey, animated values) wasn’t correctly reset when the data prop changed. The previous implementation mutatedactiveKeydirectly during render without callingreset(), leaving shared animated values stale and potentially causing gesture bugs or UI inconsistencies. Having thereset()called too earlier made the UI glitch as it was rendering faster than the state change were processed.We now defer the
reset()call usingInteractionManager.runAfterInteractions()to safely clear both React and Reanimated state after the render pass.Why this matters: