Separate the path where temporary files uploaded by the user are stor…#177
Merged
grantcopley merged 1 commit intocoldbox-modules:nextfrom Feb 20, 2025
Conversation
…ed in a configuration variable
Collaborator
|
Thanks @linuxonrails! I'll pull this down today and do some testing. This will be a nice addition! |
grantcopley
approved these changes
Feb 20, 2025
Collaborator
grantcopley
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the added feature @linuxonrails!
I'm merging this into the next branch which means it will be a part of the 4.2.0-snapshot builds for now and included when CBWIRE 4.2 is released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate the path where temporary files uploaded by the user are stored in a configuration variable.
We need to save the temporary images uploaded by the files (
<input wire:model="..." ...>) in a different directory than the configuration directory so that it is shared by all front-end server machines.This change creates a new configuration variable (
storagePath) that keeps the original default value, but allows the developer to change that directory to a different one with a simple change: