fix: issue-triage quick wins (extraction, MCP probes, gitignore, CJK, impact)#654
Merged
Conversation
… impact) Batch of small, localized fixes from an open-issue triage: - .codegraph/.gitignore now ignores everything but itself, so the database, daemon.pid, sockets, and logs stop showing up in git status (#492, #484) - MCP server answers resources/list and prompts/list with empty lists instead of -32601, clearing scary log lines in opencode/Codex (#621) - index SAP HANA .xsjs/.xsjslib as JavaScript (#556) and TS .mts/.cts (#366) - visit anonymous AMD/CommonJS/IIFE wrapper bodies so their inner functions and calls are indexed instead of coming up empty (#528) - batch the changed-file lookup so a huge first sync no longer hits "too many SQL variables" (#540) - list files with `git ls-files -z` so non-ASCII/CJK paths survive core.quotepath and are no longer silently skipped (#541) - attach Go methods on generic receivers (*T[P]) to their type (#583, RC1) - impact no longer climbs the structural `contains` edge, so a leaf symbol stops dragging in its sibling methods (#536) - README: explicit `codegraph install` step, run in a new shell (#631) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maxmilian
added a commit
to maxmilian/codegraph
that referenced
this pull request
Jun 3, 2026
…olbymchenry#556) The extraction half of colbymchenry#556 — indexing `.xsjs` / `.xsjslib` as JavaScript — already landed on main via colbymchenry#654. This PR is now scoped to the remaining resolution gap: the JS import-resolution list did not include the SAP HANA extensions, so an extensionless `import { x } from './helpers'` in a `.xsjs` file resolved to nothing and the cross-file call edge was dropped. Add `.xsjs` / `.xsjslib` to the `javascript` entry in EXTENSION_RESOLUTION so those imports resolve to their target file and `codegraph_callers` / `codegraph_impact` see the edge. One resolution test covers the .xsjs -> .xsjslib import; the now-redundant extraction/detection tests were dropped (covered by colbymchenry#654).
maxmilian
added a commit
to maxmilian/codegraph
that referenced
this pull request
Jun 10, 2026
…olbymchenry#556) The extraction half of colbymchenry#556 — indexing `.xsjs` / `.xsjslib` as JavaScript — already landed on main via colbymchenry#654. This PR is now scoped to the remaining resolution gap: the JS import-resolution list did not include the SAP HANA extensions, so an extensionless `import { x } from './helpers'` in a `.xsjs` file resolved to nothing and the cross-file call edge was dropped. Add `.xsjs` / `.xsjslib` to the `javascript` entry in EXTENSION_RESOLUTION so those imports resolve to their target file and `codegraph_callers` / `codegraph_impact` see the edge. One resolution test covers the .xsjs -> .xsjslib import; the now-redundant extraction/detection tests were dropped (covered by colbymchenry#654).
colbymchenry
added a commit
that referenced
this pull request
Jun 11, 2026
… is ignored (#788) (#802) Versions <= 0.9.9 wrote an explicit-allowlist .codegraph/.gitignore (*.db, cache/, .dirty, ...) that never listed daemon.pid or the socket, so the daemon's runtime pidfile got committed. The wildcard rewrite in #654/#492/#484 fixed new inits, but the file is only written when absent, so existing installs kept their stale file forever — the fix never reached the people hitting it. Make the gitignore self-heal: ensureGitignore() writes the file if absent and upgrades a stale CodeGraph-generated default in place, leaving a user-authored file untouched. A "stale default" is one that carries our `# CodeGraph data files` header but predates the wildcard ignore (no bare `*` line) — a header match heals every historical variant (v0.7.x..0.9.9, all verified to share it) and is idempotent. validateDirectory() runs on every open()/openSync(), so existing repos heal on the next codegraph command after upgrading. The duplicated template (previously inlined in two formats) is consolidated into one GITIGNORE_CONTENT constant. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maxmilian
added a commit
to maxmilian/codegraph
that referenced
this pull request
Jun 12, 2026
…olbymchenry#556) The extraction half of colbymchenry#556 — indexing `.xsjs` / `.xsjslib` as JavaScript — already landed on main via colbymchenry#654. This PR is now scoped to the remaining resolution gap: the JS import-resolution list did not include the SAP HANA extensions, so an extensionless `import { x } from './helpers'` in a `.xsjs` file resolved to nothing and the cross-file call edge was dropped. Add `.xsjs` / `.xsjslib` to the `javascript` entry in EXTENSION_RESOLUTION so those imports resolve to their target file and `codegraph_callers` / `codegraph_impact` see the edge. One resolution test covers the .xsjs -> .xsjslib import; the now-redundant extraction/detection tests were dropped (covered by colbymchenry#654).
maxmilian
added a commit
to maxmilian/codegraph
that referenced
this pull request
Jun 17, 2026
…olbymchenry#556) The extraction half of colbymchenry#556 — indexing `.xsjs` / `.xsjslib` as JavaScript — already landed on main via colbymchenry#654. This PR is now scoped to the remaining resolution gap: the JS import-resolution list did not include the SAP HANA extensions, so an extensionless `import { x } from './helpers'` in a `.xsjs` file resolved to nothing and the cross-file call edge was dropped. Add `.xsjs` / `.xsjslib` to the `javascript` entry in EXTENSION_RESOLUTION so those imports resolve to their target file and `codegraph_callers` / `codegraph_impact` see the edge. One resolution test covers the .xsjs -> .xsjslib import; the now-redundant extraction/detection tests were dropped (covered by colbymchenry#654).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A batch of small, self-contained fixes from triaging the open-issue backlog. Each one is localized and independently tested; the suite is green (1119 passed, 2 skipped).
Fixes
.codegraph/cluttersgit status— the generated.codegraph/.gitignorenow ignores everything in the folder except itself, so the database,daemon.pid, sockets, and logs stop appearing as untracked changes. Closes Bug:.codegraph/.gitignorefails to prevent the.codegraph/directory itself from being tracked by Git #492, closes why.codegraph/daemon.pidnot ignored #484.-32601on connect — the server now answersresources/list/prompts/list(andresources/templates/list) with empty lists instead of MethodNotFound, clearing the error lines some clients (opencode, Codex) logged on connect. Closes MCP error -32601: resources/list and prompts/list not implemented #621..xsjs/.xsjslibnow index as JavaScript (closes SAP xsjs and xsjslib files from SAP HANA 1.0 are js files but ignored by codegraph #556); TypeScript.mts/.ctsnow index as TypeScript (closes .mts / .mjs files are not indexed (ESM TypeScript/JS module extensions skipped by file discovery) #366).git ls-files -z, so paths under CJK-named directories survive git'score.quotepathquoting instead of being silently dropped from the index. Closes Files under directories with non-ASCII (CJK) names are silently skipped during indexing #541.containsedge upward, so a leaf symbol stops dragging in every sibling method of its class. Closes Siblings shouldn't be included in impact by default #536.codegraph installstep, run in a new shell so the freshly-PATH'd binary resolves. Closes The README has conflicting Get Started and Quick Start Sections. If you follow "Get Started", the MCP server never gets wired up and your agent silently has no codegraph. #631.func (s *Stack[T]) Push(...)now attach to their type, so callers/callees/impact include them. Refs Go: receiver methods dropped from their type — generic receivers (*T[P]) and cross-file declarations lose the struct→methodcontainsedge #583 — this is the generic-receiver regex (RC1); the cross-file-receiver half of that issue is left open.Testing
containsedge #583,.mts/.cts/.xsjs), graph impact (Siblings shouldn't be included in impact by default #536), foundation gitignore (Bug:.codegraph/.gitignorefails to prevent the.codegraph/directory itself from being tracked by Git #492/why.codegraph/daemon.pidnot ignored #484), and an end-to-end MCPresources/list/prompts/listtest (MCP error -32601: resources/list and prompts/list not implemented #621)..codegraph/.gitignorecontents.🤖 Generated with Claude Code