Support for invoking and processing queries - #141

Merged

DeRauk merged 20 commits into

coinbase:masterfrom

dwillett:features/query-support

Apr 15, 2022

dwillett commented Feb 18, 2022 •

edited

Loading

Contributor

Adding support for queries.

This PR leaves a few things unimplemented:

A "catch-all" query handler syntax similar to signal handlers.
Support for reserved query handler behaviors such as responding to __stack_trace, or support for populating the query UX on the web interface.

antstorm reviewed

View reviewed changes

antstorm left a comment

Contributor

Added a few comments, but this is really great progress 🎉

examples/workflows/query_workflow.rb Outdated

lib/temporal/metadata.rb Outdated

lib/temporal/metadata/workflow_task.rb Outdated

lib/temporal/workflow/dispatcher.rb Outdated

lib/temporal/workflow/dispatcher.rb Outdated

lib/temporal/workflow/context.rb

lib/temporal/workflow/task_processor.rb Outdated

chuckremes2 reviewed

View reviewed changes

examples/spec/integration/query_workflow_spec.rb

chuckremes2 reviewed

View reviewed changes

examples/spec/integration/query_workflow_spec.rb

chuckremes2 reviewed

View reviewed changes

lib/temporal/client.rb

chuckremes2 reviewed

View reviewed changes

lib/temporal/connection/grpc.rb Outdated

chuckremes2 reviewed

View reviewed changes

lib/temporal/connection/grpc.rb Outdated

chuckremes2 reviewed

View reviewed changes

lib/temporal/testing/local_workflow_context.rb Outdated

chuckremes2 reviewed

View reviewed changes

lib/temporal/workflow/executor.rb Outdated

dwillett commented

View reviewed changes

lib/temporal/connection/grpc.rb Outdated

dwillett commented

View reviewed changes

lib/temporal/workflow/dispatcher.rb Outdated

chuckremes2 reviewed

View reviewed changes

lib/temporal/workflow/context.rb Outdated

chuckremes2 reviewed

View reviewed changes

lib/temporal/workflow/context.rb Outdated

Dave Willett added 6 commits

March 24, 2022 11:27


          Support for invoking and processing queries, WIP

d146caf


          Catch-all query handler support, feedback changes

3594d90

Made a handful of changes on approach from the initial spike. This
is operating under an assumption that the added EventTarget type for
query is a valid approach


          Fixes for on_query interface, clean up workflow and spec

c2ae6a5


          Fix method signature on testing context

67bb911


          Move catch-all handler back to block

379d9e1

Also adding a second targeted query handler to spec


          Use nil workflow class in test case

116b02e

dwillett force-pushed the features/query-support branch from f641e1f to 116b02e Compare

March 24, 2022 20:30

Dave Willett and others added 11 commits

March 25, 2022 09:44


          Updates to remove catch all handling, add query reject handling

6e231d7


          More concise when no status returned from server

276182a


          More consistent raise message style

a32a55b


          Add test for reject condition not met

733c3cb


          Simplify legacy handling and use serializers for query protos

ab789ea


          Add specs for the new changes

fd9e279


          Test query result & freeze them

c775586


          Implement QueryRegistry

54bc7a1


          Swap Context#query_handlers with QueryRegistry

59e6700


          Add a spec for Workflow::Context

c6d00ff


          Rename QueryFailedFailure error to QueryFailed

4ba9b41

dwillett and others added 3 commits

April 12, 2022 08:09


          Merge branch 'coinbase:master' into features/query-support

7ba20de


          Small cleanup items

096e087


          Update readme

ecea8f2

dwillett marked this pull request as ready for review

April 12, 2022 16:11

antstorm approved these changes

View reviewed changes

antstorm left a comment

Contributor

🎉 🎉 🎉

DeRauk merged commit 398fd24 into coinbase:master

dwillett deleted the features/query-support branch

April 18, 2022 23:06

djung335 mentioned this pull request

support for query functionality coinbase/cadence-ruby#75

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet