Repo hardening: fix install instructions, dead imports, hygiene#2
Open
cognis-digital wants to merge 5 commits into
Open
Repo hardening: fix install instructions, dead imports, hygiene#2cognis-digital wants to merge 5 commits into
cognis-digital wants to merge 5 commits into
Conversation
- remove 6 unused import(s) (ruff F401/F811) - add a standard Python .gitignore
cognis-digital
force-pushed
the
cognis-audit/repo-hardening
branch
from
7cd049d to
da26624
Compare
…-06-13) - README install instructions point at the working git+https path - ran the actual audit: 2 tests passed, 0 parse errors, CLI C:\Python314\python.exe: No module named https - embedded results in README ## Verification and AUDIT.md
…age reference - layman.md: plain-English description for non-technical readers - README.md: insert What is this? section and comprehensive Install section - install.sh + install.ps1: cross-platform install scripts (pipx/uv/pip/source) - AUDIT.md + README Verification: fix wrong package name (https -> cognis_code) and broken CLI reference (python -m https -> cognis-code)
- cli.py: top-level exception guard; ide subcommand catches ValueError/OSError with clear stderr messages and non-zero exit codes; IDE list shown on error - models.py: resolve() raises ValueError for empty/None role; warns on unknown role instead of silently falling back with no indication - ide.py: validate endpoint (must be http/https, non-empty); validate ide name type/emptiness; improved ValueError message includes known IDE list - serve.py: pull() validates role against MODELS before calling ollama; both pull() and serve() catch FileNotFoundError/OSError from subprocess - webhook.py: validate URL scheme; guard empty stdin payload with warning; validate header format (Key: Value); distinguish HTTPError/URLError/Timeout - tests/test_hardening.py: 18 new tests covering all added error paths - ruff E401/E702/E701 style issues resolved across all modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:
Each change is deterministic; all touched Python files were confirmed to still compile (
py_compile) before this PR was opened.