This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Error coder sh commands if the env requires a rebuild#163
Merged
Conversation
deansheather
approved these changes
Oct 29, 2020
| makeLoginCmd(), | ||
| makeLogoutCmd(), | ||
| makeShellCmd(), | ||
| shCmd(), |
Member
There was a problem hiding this comment.
Why the rename of this particular command? Consistency seems better here, so we should change them all or not change this one.
Contributor
Author
There was a problem hiding this comment.
Yeah fair point. Just updated all uses of make*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.clubhouse.io/coder/story/352/reject-or-warn-on-coder-sh-when-an-environment-needs-to-be-rebuilt