fix(theme): align user menu profile label with password change page#3145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When logged in, the user dropdown menu on the search screen shows a different label depending on the UI: the default JSP view displays "Change Password" (
labels.profile), while the bootstrap theme displays "Profile" (nav.profile). Both link to the same/profilepage, which only provides password change functionality. This PR unifies the theme menu label with the default view.Changes Made
nav.profileinsrc/main/webapp/themes/bootstrap/i18n/messages.*.json(16 locales) to match the correspondinglabels.profiletranslation infess_label_*.properties(e.g. en:Profile->Change Password, ja:プロファイル->パスワード変更)auth.js; only the translated values were updatedTesting
Breaking Changes
Additional Notes
/profilepage only implements password changes. The theme's own page title (profile.title) already uses "Change Password", so this also resolves an inconsistency within the theme itself.