Skip to content
This repository was archived by the owner on May 21, 2025. It is now read-only.

Comments

Added sleep between upload retries.#295

Merged
thomasrockhu merged 3 commits intocodecov:masterfrom
nmoinvaz:improvements/retry-wait
Sep 14, 2020
Merged

Added sleep between upload retries.#295
thomasrockhu merged 3 commits intocodecov:masterfrom
nmoinvaz:improvements/retry-wait

Conversation

@nmoinvaz
Copy link
Contributor

@nmoinvaz nmoinvaz commented Aug 30, 2020

See #293.

@nmoinvaz
Copy link
Contributor Author

nmoinvaz commented Aug 30, 2020 •
edited
Loading

Not sure why the failure on black on a single instance. I checked manually and that file tests\test.py appears fine which I don't even touch in this PR.

@blueyed blueyed mentioned this pull request Aug 31, 2020
Open
@nmoinvaz nmoinvaz changed the title Added sleep between upload retries with increasing wait. Added sleep between upload retries. Aug 31, 2020
@nmoinvaz
Copy link
Contributor Author

nmoinvaz commented Aug 31, 2020

This PR:

  • Adds sleep 2s for each retry (same as codecov bash uploader)
  • Sets default retries to 5 (same as codecov bash uploader)
  • Logs retry attempts to output for debugging.

ktbarrett
ktbarrett reviewed Sep 12, 2020
View reviewed changes
@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #295 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #295   +/-   ##
=====================================
  Coverage      88%    88%           
=====================================
  Files           2      2           
  Lines           9      9           
=====================================
  Hits            8      8           
  Misses          1      1

@nmoinvaz
Copy link
Contributor Author

nmoinvaz commented Sep 14, 2020

I have fixed the CI issue.

@thomasrockhu thomasrockhu merged commit 2574d1b into codecov:master Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ktbarrett ktbarrett ktbarrett left review comments

@thomasrockhu thomasrockhu thomasrockhu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nmoinvaz @thomasrockhu @ktbarrett