Skip to content

fix: hardcoded Infisical ID + branding footer on no-issues (#62)#66

Merged
ajianaz merged 1 commit into
developfrom
chore/security-and-branding
Jun 1, 2026
Merged

fix: hardcoded Infisical ID + branding footer on no-issues (#62)#66
ajianaz merged 1 commit into
developfrom
chore/security-and-branding

Conversation

@ajianaz
Copy link
Copy Markdown
Collaborator

@ajianaz ajianaz commented Jun 1, 2026

Changes

Security: Hardcoded Infisical identity-id

  • release.yml: identity-id hardcoded → ${{ secrets.INFISICAL_IDENTITY_ID }}
  • deploy-website.yml: same fix
  • All 3 workflows now consistently use GitHub Secret (matches ci.yml pattern)

Branding: Footer on no-issues comment (#62)

  • PR review "No issues found" message now includes branding footer
  • Both empty-SARIF and zero-results paths fixed
  • Footer matches the existing "issues found" variant

Closes #62

Summary by CodeRabbit

  • New Features

    • PR code review feedback messages now include an attribution footer line when no issues are detected.
  • Chores

    • Improved security configuration in deployment and release workflows by transitioning to environment-based secrets management instead of static identifiers.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8122fe60-0d06-4860-b1bd-c765d314df1a

📥 Commits

Reviewing files that changed from the base of the PR and between 45717a1 and 67b67e3.

📒 Files selected for processing (3)
  • .github/actions/cora-review/action.yml
  • .github/workflows/deploy-website.yml
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

Three independent updates: the cora-review action adds a branding footer to its "no issues found" PR comment, and both deploy-website and release workflows are updated to use a dynamic Infisical identity ID from repository secrets instead of hardcoded values.

Changes

Branding footer for review comments

Layer / File(s) Summary
No-issues message footer in cora-review action
.github/actions/cora-review/action.yml
The "No issues found" message branches in the cora-review action are updated to include the footer line "Review powered by cora-cli · BYOK · MIT".

Infisical identity configuration

Layer / File(s) Summary
Infisical identity ID in workflows
.github/workflows/deploy-website.yml, .github/workflows/release.yml
The identity-id input for Infisical/secrets-action is changed from hardcoded UUID strings to ${{ secrets.INFISICAL_IDENTITY_ID }} in both the Cloudflare Pages deploy and crate release workflows.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • ajianaz/cora-cli#46: Modifies the same cora-review action PR-comment generation logic for the "no issues found" case.

Poem

🐰 A footer now graces the "all clear" refrain,
And secrets replace those hardcoded chains,
Small tweaks to the workflows, consistent and sound—
Brand pride and safe auth, all safely found! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes both main changes: replacing hardcoded Infisical identity with secrets and adding branding footer to no-issues comments.
Linked Issues check ✅ Passed The PR directly addresses issue #62 by adding the branding footer to the no-issues PR comment in the cora-review action, as required.
Out of Scope Changes check ✅ Passed The Infisical identity-id changes in release.yml and deploy-website.yml are security-related improvements aligned with the PR objectives, though not explicitly required by issue #62.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/security-and-branding

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

🔍 Cora AI Code Review

No issues found. Code looks good!


Review powered by cora-cli · BYOK · MIT

@ajianaz ajianaz merged commit 1b97a79 into develop Jun 1, 2026
8 checks passed
@ajianaz ajianaz deleted the chore/security-and-branding branch June 1, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: Add branding footer to PR review comments

1 participant