Skip to content

fix(ci): address cora self-review findings#45

Closed
ajianaz wants to merge 1 commit into
developfrom
fix/cora-self-review-findings
Closed

fix(ci): address cora self-review findings#45
ajianaz wants to merge 1 commit into
developfrom
fix/cora-self-review-findings

Conversation

@ajianaz
Copy link
Copy Markdown
Collaborator

@ajianaz ajianaz commented May 30, 2026

Self-Review by Cora 🐕

Cora found 4 issues in its own CI workflow:

  1. Infisical identity-id hardcoded → moved to INFISICAL_IDENTITY_ID secret
  2. 2>&1 mixing stderr into SARIF → removed (only stdout)
  3. || true masking failures → removed (fail loudly)
  4. SARIF upload on empty file → guarded with hashFiles

Required setup

Add GitHub repo secret INFISICAL_IDENTITY_ID with value 6bd2b8d8-a9a3-4331-8b37-bf2764fc320b

- Move Infisical identity-id to secret (INFISICAL_IDENTITY_ID)
- Remove 2>&1 redirect (was mixing stderr into SARIF JSON)
- Remove || true (was masking failures)
- Guard SARIF upload with hashFiles check
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 30, 2026

Warning

Review limit reached

@ajianaz, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 14 minutes and 27 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d5ddbe3e-aa4d-4955-a5fc-1b88c55da5cc

📥 Commits

Reviewing files that changed from the base of the PR and between c6eeb2f and bee45f1.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cora-self-review-findings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

🔍 Cora AI Code Review

No issues found. Code looks good!

@ajianaz
Copy link
Copy Markdown
Collaborator Author

ajianaz commented May 30, 2026

Superseded by #46 (composite action refactor includes all fixes)

@ajianaz ajianaz closed this May 30, 2026
@ajianaz ajianaz deleted the fix/cora-self-review-findings branch May 30, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant