[pull] master from mozilla:master#281
Merged
pull[bot] merged 8 commits intocode:masterfrom Mar 21, 2026
Merged
Conversation
The XFA development work has been completed, with mostly regular maintance/bugfixing remaining, so while this special-casing for the tests made sense at the time we should now be able to remove it (see also #11851 (comment)).
It fixes #20930. And use the defaultVMetrics (coming from DW2 property) in the font.
…al` parameter (PR 20928 follow-up)
After the changes in PR 20928 the code no longer works correctly unless the `abortSignal` parameter is provided, which completely breaks text-selection in e.g. the standalone viewer-components with errors such as:
```
#renderTextLayer: TypeError: EventTarget.addEventListener: 'signal' member of AddEventListenerOptions is not an object.
#bindMouse http://localhost:8888/web/text_layer_builder.js:173
render http://localhost:8888/web/text_layer_builder.js:128
#renderTextLayer http://localhost:8888/web/pdf_page_view.js:532
resultPromise http://localhost:8888/web/pdf_page_view.js:1184
promise callback*draw http://localhost:8888/web/pdf_page_view.js:1174
renderView http://localhost:8888/web/pdf_rendering_queue.js:219
forceRendering http://localhost:8888/web/pdf_viewer.js:2081
promise callback*forceRendering http://localhost:8888/web/pdf_viewer.js:2080
renderHighestPriority http://localhost:8888/web/pdf_rendering_queue.js:84
update http://localhost:8888/web/pdf_viewer.js:1895
onScaleChanging http://localhost:8888/web/app.js:2755
dispatch http://localhost:8888/web/event_utils.js:115
#setScaleUpdatePages http://localhost:8888/web/pdf_viewer.js:1555
#setScale http://localhost:8888/web/pdf_viewer.js:1640
set currentScaleValue http://localhost:8888/web/pdf_viewer.js:592
setInitialView http://localhost:8888/web/app.js:1969
load http://localhost:8888/web/app.js:1570
promise callback*load/< http://localhost:8888/web/app.js:1518
promise callback*load http://localhost:8888/web/app.js:1507
open http://localhost:8888/web/app.js:1255
promise callback*open http://localhost:8888/web/app.js:1253
run http://localhost:8888/web/app.js:895
webViewerLoad http://localhost:8888/web/viewer.js:366
<anonymous> http://localhost:8888/web/viewer.js:377
pdf_page_view.js:547:15
```
…to the pageNumber Currently it's only possible to trigger page-render debugging through the page number, but when looking at the /Pages tree it's often not immediately obvious what the page number actually is. However, the /Ref of the page is directly available and it's thus handy to be able to use that one instead to enable page-render debugging.
[Debugger] Allow debugging page-rendering from the /Ref, in addition to the page number
…rtSignal Ensure that `TextLayerBuilder` works correctly without the `abortSignal` parameter (PR 20928 follow-up)
Fix charSpacing in vertical mode
Remove the `xfatest` command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )