Skip to content

Patterns#66

Merged
ognjenkatic merged 19 commits into
masterfrom
feat/master/patterns
Oct 27, 2022
Merged

Patterns#66
ognjenkatic merged 19 commits into
masterfrom
feat/master/patterns

Conversation

@ognjenkatic

@ognjenkatic ognjenkatic commented Oct 17, 2022

Copy link
Copy Markdown
Collaborator

This PR extracts all the AddTask(..) methods from the WorkflowDefinitionBuilder and places them as extension methods into the same file with the specific task builder.

This approach can be replicated by any assembly, and in that way we can add more builders. It also adds a small library of premade tasks along with their builders for easier adding with AddTask(..)

@ognjenkatic ognjenkatic marked this pull request as draft October 17, 2022 21:14
@ognjenkatic ognjenkatic requested a review from boma96 October 18, 2022 12:49
@ognjenkatic ognjenkatic marked this pull request as ready for review October 18, 2022 12:50
Comment thread src/ConductorSharp.Patterns/Tasks/WaitSeconds.cs Outdated
Comment thread src/ConductorSharp.Patterns/Tasks/ReadWorkflowTasks.cs Outdated
Comment thread src/ConductorSharp.Engine/Builders/WorkflowDefinitionBuilder.cs Outdated
Comment thread src/ConductorSharp.Engine/Builders/WorkflowDefinitionBuilder.cs Outdated
Comment thread src/ConductorSharp.Engine/Builders/WorkflowDefinitionBuilder.cs Outdated
Comment thread src/ConductorSharp.Engine/Builders/WorkflowDefinitionBuilder.cs Outdated
@ognjenkatic ognjenkatic requested a review from boma96 October 24, 2022 18:34
Comment thread src/ConductorSharp.Patterns/Tasks/ReadWorkflowTasks.cs Outdated
@ognjenkatic ognjenkatic requested a review from boma96 October 27, 2022 18:08
@ognjenkatic ognjenkatic merged commit a863a5d into master Oct 27, 2022
@ognjenkatic ognjenkatic deleted the feat/master/patterns branch October 27, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants