Allow workflow and worker referencing with builder#53
Merged
ognjenkatic merged 7 commits intoSep 11, 2022
Conversation
ognjenkatic
deleted the
feat/master/allow-workflow-referencing-with-builder
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the capability to directly reference classes that inherrit
WorkflowandTaskRequestHandlerin workflow definitions. This should reduce the amount of classes that we have to write in the following ways:SubWorkflowTaskModelclass for workflows we created ourselves just to be able to reference it in other workflows as a subworkflow.SimpleTaskModelclass if we access to the worker class that inheritsTaskRequestHandler(this is a new addition, a sort of base class that implementsITaskRequestHandler). This case should not really happen as we recommend that workflow definitions are kept separate from workers, but it could help some users.