Add support for conditional scaffolding#48
Merged
Conversation
ognjenkatic
reviewed
Sep 6, 2022
ognjenkatic
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, but I cannot see where we are setting the value of the dryrun option? Did i miss something ?
Collaborator
Author
Forgot about this, will implement |
Collaborator
Author
|
@ognjenkatic Dry run option is implemented, check PR description |
Collaborator
Looks good now, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following options are added to the toolkit:
For name, app, and email filters multiple values can be specified e.g. -n A_task1 B_task2.
Name filter supports special character % which matches zero or more characters
When multiple filters of different types are present then AND operation is applied i.e. all filters must be satisfied in order for wf/task to be scaffolded.