Skip to content

Add support for conditional scaffolding#48

Merged
ognjenkatic merged 20 commits into
masterfrom
feat/master/conditional-scaffolding
Sep 7, 2022
Merged

Add support for conditional scaffolding#48
ognjenkatic merged 20 commits into
masterfrom
feat/master/conditional-scaffolding

Conversation

@boma96

@boma96 boma96 commented Sep 6, 2022

Copy link
Copy Markdown
Collaborator

Following options are added to the toolkit:

  • -n, --name (Specifies names of the tasks and workflows to scaffold)
  • -a, --app (Specifies owner apps of the tasks and workflows to scaffold)
  • -e, --email (Specifies owner emails of the tasks and workflows to scaffold)
  • --no-tasks (Skip task scaffolding)
  • --no-workflows (Skip workflow scaffolding)
  • --dry-run (Print workflows and task which would be scaffolded if toolkit is ran without this option)

For name, app, and email filters multiple values can be specified e.g. -n A_task1 B_task2.
Name filter supports special character % which matches zero or more characters

When multiple filters of different types are present then AND operation is applied i.e. all filters must be satisfied in order for wf/task to be scaffolded.

@boma96 boma96 requested a review from ognjenkatic September 6, 2022 13:40

@ognjenkatic ognjenkatic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I cannot see where we are setting the value of the dryrun option? Did i miss something ?

@boma96

boma96 commented Sep 7, 2022

Copy link
Copy Markdown
Collaborator Author

LGTM, but I cannot see where we are setting the value of the dryrun option? Did i miss something ?

Forgot about this, will implement

@boma96

boma96 commented Sep 7, 2022

Copy link
Copy Markdown
Collaborator Author

@ognjenkatic Dry run option is implemented, check PR description

@ognjenkatic

Copy link
Copy Markdown
Collaborator

@ognjenkatic Dry run option is implemented, check PR description

Looks good now, merging.

@ognjenkatic ognjenkatic merged commit 8135c70 into master Sep 7, 2022
@ognjenkatic ognjenkatic deleted the feat/master/conditional-scaffolding branch September 7, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants