Skip to content

Read version attribute from subworkflow models#45

Merged
ognjenkatic merged 7 commits into
masterfrom
fix/master/subworkflow-version
Sep 5, 2022
Merged

Read version attribute from subworkflow models#45
ognjenkatic merged 7 commits into
masterfrom
fix/master/subworkflow-version

Conversation

@boma96

@boma96 boma96 commented Sep 5, 2022

Copy link
Copy Markdown
Collaborator

The workflow version was hard coded to 1 when specifying sub-workflow.
The solution was to add a Version attribute which is checked during workflow build.

@boma96 boma96 requested a review from ognjenkatic September 5, 2022 12:32

@ognjenkatic ognjenkatic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ognjenkatic ognjenkatic merged commit 36f18a4 into master Sep 5, 2022
@ognjenkatic ognjenkatic deleted the fix/master/subworkflow-version branch September 5, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants