Add support for input parameter array initialization#28
Merged
Conversation
ognjenkatic
reviewed
Jul 29, 2022
ognjenkatic
left a comment
Collaborator
There was a problem hiding this comment.
One note regarding type conversions
Comment on lines
+76
to
+81
| private static JArray ParseArrayInitalization(NewArrayExpression newArrayExpression) | ||
| { | ||
| if (newArrayExpression.NodeType != ExpressionType.NewArrayInit) | ||
| throw new Exception("Only dimensionless array initialization is supported"); | ||
|
|
||
| return new JArray(newArrayExpression.Expressions.Select(ParseExpression)); |
Collaborator
There was a problem hiding this comment.
This seems to return [ 1,2,3] as ["1", "2", "3"]. The reason is
if (expression is ConstantExpression cex)
return Convert.ToString(cex.Value);
@boma96
We can extract the correct type, but this might break something somewhere. However, most frameworks seem to be equipped to handle string to int conversion automatically if it is really convertible. I think we should do this, what do you think?
Collaborator
There was a problem hiding this comment.
It will also break our tests
Collaborator
Author
There was a problem hiding this comment.
Thank you for pointing this out, did not notice it
Collaborator
Author
There was a problem hiding this comment.
Ok, will make separate PR for this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now it is possible to specify array as input parameter