Add toolkit project, make dotnet tool#18
Merged
Conversation
ognjenkatic
requested changes
Jun 30, 2022
ognjenkatic
left a comment
Collaborator
There was a problem hiding this comment.
We could remove some of the repetitive code from the old codebase with this PR before moving on to refactoring. (Only the things that don't require a lot of effort and do not affect functionality).
There was a lot of code that was thrown together by myself and other developers and which we would rather forget about :)
Collaborator
|
There are also some conflicts to resolve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toolkit is added to the project.
Beside that following things are done as well:
dotnet conductorsharpcommandCurrently, the tool works only with version 2 of the conductor. We have to think through how to adapt tool for the Sp1ne project.