Skip to content

Add toolkit project, make dotnet tool#18

Merged
ognjenkatic merged 37 commits into
masterfrom
feat/master/toolkit
Jul 20, 2022
Merged

Add toolkit project, make dotnet tool#18
ognjenkatic merged 37 commits into
masterfrom
feat/master/toolkit

Conversation

@boma96

@boma96 boma96 commented Jun 25, 2022

Copy link
Copy Markdown
Collaborator

The toolkit is added to the project.
Beside that following things are done as well:

  • Class namespaces are adjusted, using statements fixed and unnecessary usings are removed
  • Classes corresponding to features we do not want currently (dllscrapper and documentation) are removed
  • Code is slightly modified in order for the tool to be runnable
    • Tool assumed that classes start with prefix consisting of capital letters (e.g. UTIL_, DB_, etc.)
  • Project is dotnet tool, i.e. it can be invoked with dotnet conductorsharp command

Currently, the tool works only with version 2 of the conductor. We have to think through how to adapt tool for the Sp1ne project.

@boma96 boma96 requested a review from ognjenkatic June 25, 2022 23:53

@ognjenkatic ognjenkatic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could remove some of the repetitive code from the old codebase with this PR before moving on to refactoring. (Only the things that don't require a lot of effort and do not affect functionality).

There was a lot of code that was thrown together by myself and other developers and which we would rather forget about :)

Comment thread src/ConductorSharp.Toolkit/Commands/CommandRegistry.cs Outdated
Comment thread src/ConductorSharp.Toolkit/Service/ScaffoldingService.cs Outdated
Comment thread src/ConductorSharp.Toolkit/Service/ScaffoldingService.cs Outdated
Comment thread src/ConductorSharp.Toolkit/Service/ScaffoldingService.cs Outdated
Comment thread src/ConductorSharp.Toolkit/Service/ScaffoldingService.cs Outdated
Comment thread src/ConductorSharp.Toolkit/Service/ScaffoldingService.cs Outdated
Comment thread src/ConductorSharp.Toolkit/Service/ScaffoldingService.cs Outdated
Comment thread src/ConductorSharp.Toolkit/Service/ScaffoldingService.cs Outdated
Comment thread src/ConductorSharp.Toolkit/Service/ScaffoldingService.cs Outdated
@ognjenkatic

Copy link
Copy Markdown
Collaborator

There are also some conflicts to resolve

@ognjenkatic ognjenkatic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@ognjenkatic ognjenkatic merged commit 6513d53 into master Jul 20, 2022
@boma96 boma96 deleted the feat/master/toolkit branch August 10, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants