Init the static members directly without __init__.#16
Open
andyli wants to merge 1 commit intocloudshift:masterfrom
Open
Init the static members directly without __init__.#16andyli wants to merge 1 commit intocloudshift:masterfrom
andyli wants to merge 1 commit intocloudshift:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialization the static members directly without
__init__.The benefit here is, with
-dce full, haxe will only generaterequire(xxx)statement for the the actually used modules.Eg.
with
-dce full, will output:Btw, I also:
require('tty');fortty, which was missing.public static var queryString:NodeQueryString;since there is alreadypublic static var querystring(default,null) : NodeQueryString;