Skip to content

zh-translation: docs/root/configuration/http/http_filters/lua_filter.rst - #711

Merged
helight merged 1 commit into
cloudnativeto:zhfrom
wujie1993:lua_filter
Apr 12, 2021
Merged

zh-translation: docs/root/configuration/http/http_filters/lua_filter.rst#711
helight merged 1 commit into
cloudnativeto:zhfrom
wujie1993:lua_filter

Conversation

@wujie1993

@wujie1993 wujie1993 commented Feb 23, 2021

Copy link
Copy Markdown
Member

issue #239

vgbhfive
vgbhfive reviewed Feb 27, 2021
View reviewed changes

@vgbhfive vgbhfive left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻译很不错，就是一些地方不是很通顺。

Comment thread docs/root/configuration/http/http_filters/lua_filter.rst Outdated
Comment thread docs/root/configuration/http/http_filters/lua_filter.rst Outdated
@wujie1993

wujie1993 commented Mar 16, 2021

Copy link
Copy Markdown
Member Author

@vgbhfive 感谢建议！已经更新

@helight
helight self-requested a review March 23, 2021 11:57
helight
helight reviewed Mar 29, 2021
View reviewed changes
Comment thread docs/root/configuration/http/http_filters/lua_filter.rst Outdated
helight
helight reviewed Mar 29, 2021
View reviewed changes
Comment thread docs/root/configuration/http/http_filters/lua_filter.rst Outdated
helight
helight reviewed Mar 29, 2021
View reviewed changes
Comment thread docs/root/configuration/http/http_filters/lua_filter.rst Outdated
helight
helight reviewed Mar 29, 2021
View reviewed changes
Comment thread docs/root/configuration/http/http_filters/lua_filter.rst Outdated
helight
helight reviewed Mar 29, 2021
View reviewed changes
Comment thread docs/root/configuration/http/http_filters/lua_filter.rst Outdated
helight
helight reviewed Mar 29, 2021
View reviewed changes
Comment thread docs/root/configuration/http/http_filters/lua_filter.rst Outdated
inetkiller
inetkiller reviewed Mar 29, 2021
View reviewed changes

@inetkiller inetkiller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

提了点小建议

Comment thread docs/root/configuration/http/http_filters/lua_filter.rst Outdated
Comment thread docs/root/configuration/http/http_filters/lua_filter.rst Outdated
helight
helight reviewed Mar 30, 2021
View reviewed changes

@helight helight left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点建议，其它都很流畅，赞

@majinghe

majinghe commented Apr 4, 2021

Copy link
Copy Markdown

@wujie1993 麻烦按照 comment 处理一下。

vgbhfive
vgbhfive reviewed Apr 4, 2021
View reviewed changes

@vgbhfive vgbhfive left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

整体翻译很棒

Comment thread docs/root/configuration/http/http_filters/lua_filter.rst Outdated
Comment thread docs/root/configuration/http/http_filters/lua_filter.rst Outdated
Comment thread docs/root/configuration/http/http_filters/lua_filter.rst Outdated

@vgbhfive vgbhfive Apr 4, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里感觉不需要翻译的。

@wujie1993 wujie1993 Apr 8, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为是代码注释，所以也连带给翻译了下

@wujie1993 @inetkiller
zh-translation: docs/root/configuration/http/http_filters/lua_filter.rst
fc25c81 
Signed-off-by: wujie1993 <qq594jj@gmail.com>

Co-authored-by: helight <helight@helight.info>

Co-authored-by: Tangyi <tinetkiller@gmail.com>
@wujie1993

wujie1993 commented Apr 8, 2021

Copy link
Copy Markdown
Member Author

@inetkiller @helight @vgbhfive 感谢建议，已提交更新

@inetkiller

inetkiller commented Apr 12, 2021

Copy link
Copy Markdown
Member

/LGTM

helight
helight approved these changes Apr 12, 2021
View reviewed changes

@helight helight left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@helight
helight merged commit 8e29fc2 into cloudnativeto:zh Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vgbhfive vgbhfive vgbhfive left review comments
@helight helight helight approved these changes
@inetkiller inetkiller inetkiller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wujie1993 @majinghe @inetkiller @helight @vgbhfive