Skip to content

fix(wrangler): hide dev hotkey bar under turborepo#13742

Draft
edmundhung wants to merge 2 commits intomainfrom
edmundhung/fix-turborepo-hotkeys
Draft

fix(wrangler): hide dev hotkey bar under turborepo#13742
edmundhung wants to merge 2 commits intomainfrom
edmundhung/fix-turborepo-hotkeys

Conversation

@edmundhung
Copy link
Copy Markdown
Member

Fixes #7814.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 29, 2026

🦋 Changeset detected

Latest commit: 959d23c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 29, 2026

I've now thoroughly reviewed the PR. The changes are clean, well-structured, and correct:

  1. is-turborepo.ts: Simple, well-designed detection function with injectable env parameter for testability. Checks the three standard Turborepo environment variables (TURBO_HASH, TURBO_TASK, TURBO_INVOCATION_DIR).

  2. start-dev.ts: Correctly extracts the condition into shouldRenderInteractiveDevSession and adds the !isTurborepo() check. Both the multi-worker and single-worker branches are updated consistently. The authHook re-registration path at line 50 correctly relies on hotkeysDisplayed (which will be false since hotkeys were never registered in the first place), so it's also safe.

  3. Unit tests: Properly use ({ expect }) from test context, pass explicit env objects rather than mutating process.env.

  4. Integration tests: Properly strip TURBO env vars from the default PTY environment (so existing hotkey tests aren't broken when the monorepo's own Turbo runner sets these vars), and add a dedicated test that sets TURBO_HASH and verifies hotkeys are hidden.

  5. Changeset: Correct format, patch level is appropriate for a bugfix.

No logic bugs, no security issues, no backward compatibility problems. The approach is pragmatic and minimal.

LGTM

github run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

✅ All changesets look good

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 29, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13742

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13742

miniflare

npm i https://pkg.pr.new/miniflare@13742

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13742

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13742

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13742

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13742

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13742

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13742

wrangler

npm i https://pkg.pr.new/wrangler@13742

commit: 959d23c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

🐛 BUG: hotkey bar renders when used with turborepo

2 participants