fix(miniflare): expose send_email in platform proxy#13723
Open
edmundhung wants to merge 2 commits intomainfrom
Open
fix(miniflare): expose send_email in platform proxy#13723edmundhung wants to merge 2 commits intomainfrom
edmundhung wants to merge 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 65a1eb5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
Contributor
Changeset ReviewFile Reviewed
Review Results✅ All changesets look good Summary
The changeset effectively communicates that |
Contributor
|
UnknownError: ProviderInitError |
Contributor
|
@edmundhung Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
2ab37cc to
4b36bb3
Compare
4b36bb3 to
ec39d73
Compare
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13715
This was not originally supported because email bindings relied on the
EmailMessageclass fromcloudflare:emailmodule, which is not available in the Node environment. Now thatsend_emailsupports the plain-objectMessageBuilderinterface, I think we should be able to enable this through thegetPlatformProxy().The local email binding previously used Miniflare's loopback server to write preview files. That deadlocks when called through the Node proxy, so this switches those file writes to a workerd disk service instead.
A picture of a cute animal (not mandatory, but encouraged)