Support stream (but keep pipeline backwards compatible) binding for Pipelines by oliy · Pull Request #13716 · cloudflare/workers-sdk

oliy · 2026-04-28T22:41:41Z

…

PIPE-374

Fixes the mismatch between original Pipeline bindings and v1 Pipeline entities. Specifically that we are binding to a Stream now, which then feeds the Pipeline that delivers traffic to a Sink. We preserve the original bindings to avoid breaking existing pipelines, but issue a warning of the deprecated usage.

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because:

A picture of a cute animal (not mandatory, but encouraged)

changeset-bot · 2026-04-28T22:41:45Z

🦋 Changeset detected

Latest commit: fd20fdf

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

workers-devprod · 2026-04-28T22:42:04Z

Codeowners approval required for this PR:

@cloudflare/wrangler

Show detailed file reviewers

packages/miniflare/src/plugins/pipelines/index.ts: [@cloudflare/wrangler]
packages/workers-utils/src/config/environment.ts: [@cloudflare/wrangler]
packages/workers-utils/src/config/validation.ts: [@cloudflare/wrangler]
packages/workers-utils/src/map-worker-metadata-bindings.ts: [@cloudflare/wrangler]
packages/workers-utils/src/types.ts: [@cloudflare/wrangler]
packages/workers-utils/src/worker.ts: [@cloudflare/wrangler]
packages/workers-utils/tests/config/validation/normalize-and-validate-config.test.ts: [@cloudflare/wrangler]
packages/wrangler/e2e/remote-binding/miniflare-remote-resources.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/tests/api/startDevWorker/LocalRuntimeController.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/tests/create-worker-upload-form/bindings.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/tests/deploy/durable-objects.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/tests/deploy/get-remote-config-diff.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/tests/dev/remote-bindings.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/tests/init.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/tests/type-generation.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/api/startDevWorker/utils.ts: [@cloudflare/wrangler]
packages/wrangler/src/deployment-bundle/create-worker-upload-form.ts: [@cloudflare/wrangler]
packages/wrangler/src/dev/miniflare/index.ts: [@cloudflare/wrangler]
packages/wrangler/src/preview/api.ts: [@cloudflare/wrangler]
packages/wrangler/src/preview/shared.ts: [@cloudflare/wrangler]
packages/wrangler/src/type-generation/index.ts: [@cloudflare/wrangler]
packages/wrangler/src/type-generation/pipeline-schema.ts: [@cloudflare/wrangler]
packages/wrangler/src/utils/print-bindings.ts: [@cloudflare/wrangler]

ask-bonk · 2026-04-28T22:47:07Z

UnknownError: ProviderInitError

github run

ask-bonk · 2026-04-28T22:47:08Z

@oliy Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

pkg-pr-new · 2026-04-28T22:48:41Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13716

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13716

miniflare

npm i https://pkg.pr.new/miniflare@13716

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13716

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13716

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13716

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13716

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13716

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13716

wrangler

npm i https://pkg.pr.new/wrangler@13716

commit: fd20fdf

github-actions · 2026-04-29T13:49:51Z

Changeset Review

Summary

✅ All changesets look good

Details

All 15 changeset files have been reviewed against the guidelines:

Version Types

Appropriate version bumps selected (patch for bug fixes/improvements, minor for new features)
drop-node-20.md correctly uses minor for dropping Node.js 20 support (significant compatibility change)
Dependency update changesets for create-cloudflare skipped per guidelines

Changelog Quality

All descriptions are meaningful and explain the user impact
Before/after examples provided where helpful (e.g., pipeline-stream-rename.md)
Technical context included where necessary (e.g., fix-buffer-devalue.md)

Markdown Headers

No h1/h2/h3 headers found in any changeset

Analytics

No analytics-related changes detected

Dependabot Changesets

Skipped validation for c3-frameworks-update-*.md files as they are dependency updates for create-cloudflare

Experimental Features

No experimental feature changes requiring opt-in notes detected

Files Reviewed

pipeline-stream-rename.md - ✅ minor, good description with examples
c3-frameworks-update-13733.md - ✅ skipped (dependabot-style C3 update)
dependabot-update-13732.md - ✅ patch for workerd update
c3-frameworks-update-13359.md - ✅ skipped (dependabot-style C3 update)
restart-from-step.md - ✅ minor for Workflows feature
shaky-parks-buy.md - ✅ minor for module fallback service
quiet-houses-attack.md - ✅ minor for Hyperdrive fix
fix-config-flag-autoconfig-opennext.md - ✅ patch for bug fix
c3-frameworks-update-13729.md - ✅ skipped (dependabot-style C3 update)
fuzzy-zoos-hear.md - ✅ patch for improvement
c3-frameworks-update-13730.md - ✅ skipped (dependabot-style C3 update)
drop-node-20.md - ✅ minor for Node.js version requirement change
router-worker-loopback.md - ✅ patch for refactoring
twelve-eggs-fetch.md - ✅ minor for Vite plugin feature
fix-buffer-devalue.md - ✅ patch for bug fix with good technical detail

…ing for Pipelines

devin-ai-integration

Devin Review found 1 new potential issue.

View 8 additional findings in Devin Review.

devin-ai-integration · 2026-04-30T07:08:34Z

+		env[pipeline.binding] = {
+			type: "pipelines",
+			pipeline: pipeline.stream || pipeline.pipeline,
+		};


🔴 extractConfigBindings writes to deprecated pipeline field instead of stream

In extractConfigBindings, the resolved stream name is assigned to the old pipeline field (pipeline: pipeline.stream || pipeline.pipeline) instead of the new stream field. Every other analogous site in the PR was correctly migrated to write to stream — for example, packages/wrangler/src/deployment-bundle/create-worker-upload-form.ts:488 writes stream: pipelineStream || pipeline, and packages/workers-utils/src/map-worker-metadata-bindings.ts:326 writes stream: binding.stream || binding.pipeline. This env object is sent directly to the Cloudflare Preview Deployment API (via assemblePreviewDefaults at packages/wrangler/src/preview/shared.ts:338 and createPreviewDeployment at packages/wrangler/src/preview/preview.ts:388-390). Since the PR's stated purpose is to align with the updated API wire format that uses stream, sending the old pipeline field could cause preview deployments to fail to recognize the pipeline binding.

Suggested change

env[pipeline.binding] = {

type: "pipelines",

pipeline: pipeline.stream || pipeline.pipeline,

};

env[pipeline.binding] = {

type: "pipelines",

stream: pipeline.stream || pipeline.pipeline,

};

Was this helpful? React with 👍 or 👎 to provide feedback.

oliy requested a review from workers-devprod as a code owner April 28, 2026 22:41

workers-devprod added this to workers-sdk Apr 28, 2026

github-project-automation Bot moved this to Untriaged in workers-sdk Apr 28, 2026

workers-devprod requested review from a team and penalosa and removed request for a team April 28, 2026 22:42

This comment was marked as resolved.

Sign in to view

oliy force-pushed the oli/pipelines_stream branch from 8459647 to d87e070 Compare April 29, 2026 13:48

This comment was marked as resolved.

Sign in to view

oliy force-pushed the oli/pipelines_stream branch 2 times, most recently from 928e085 to bad292e Compare April 30, 2026 06:40

This comment was marked as resolved.

Sign in to view

PIPE-374 Support stream (but keep pipeline backwards compatible) bind…

fd20fdf

…ing for Pipelines

oliy force-pushed the oli/pipelines_stream branch from bad292e to fd20fdf Compare April 30, 2026 07:04

devin-ai-integration Bot reviewed Apr 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support stream (but keep pipeline backwards compatible) binding for Pipelines#13716

Support stream (but keep pipeline backwards compatible) binding for Pipelines#13716
oliy wants to merge 1 commit intomainfrom
oli/pipelines_stream

oliy commented Apr 28, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Apr 28, 2026 •

edited

Loading

Uh oh!

workers-devprod commented Apr 28, 2026 •

edited

Loading

Uh oh!

This comment was marked as resolved.

Uh oh!

ask-bonk Bot commented Apr 28, 2026

Uh oh!

ask-bonk Bot commented Apr 28, 2026

Uh oh!

pkg-pr-new Bot commented Apr 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

devin-ai-integration Bot Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

oliy commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

workers-devprod commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

ask-bonk Bot commented Apr 28, 2026

Uh oh!

ask-bonk Bot commented Apr 28, 2026

Uh oh!

pkg-pr-new Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset Review

Summary

Details

Version Types

Changelog Quality

Markdown Headers

Analytics

Dependabot Changesets

Experimental Features

Files Reviewed

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

oliy commented Apr 28, 2026 •

edited

Loading

changeset-bot Bot commented Apr 28, 2026 •

edited

Loading

workers-devprod commented Apr 28, 2026 •

edited

Loading

pkg-pr-new Bot commented Apr 28, 2026 •

edited

Loading

github-actions Bot commented Apr 29, 2026 •

edited

Loading