Change daily release version patch to 0#6715
Change daily release version patch to 0#6715DaniFoldi wants to merge 1 commit intocloudflare:mainfrom
Conversation
penalosa
left a comment
There was a problem hiding this comment.
Thanks for this! For context, this was changed because we had a period in early March where the minor version of workerd was conflicting with already publishd versions, and so we wanted to keep daily publishes succeeding and not conflicting.
Merging this PR will degrade performance by 28.58%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | simpleStringBody[Response] |
19.2 µs | 26.9 µs | -28.58% |
Comparing DaniFoldi:fix-release-patch-version (894b495) with main (e612e24)
Footnotes
-
129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
I noticed that lately the automatically released versions of workerd and workers-types end with
.1. I found that 586925d introducedworkerd/.github/workflows/release.yml
Lines 33 to 37 in e612e24
and I believe the
&& '0'->&& '1'changes weren't intentional. cc @penalosa as the author of the daily versioning script, apologies if I missed something that makes it necessary.