Populate rawHeaders on Node.js HTTP client responses#6712
Open
mhart wants to merge 1 commit intocloudflare:mainfrom
Open
Populate rawHeaders on Node.js HTTP client responses#6712mhart wants to merge 1 commit intocloudflare:mainfrom
mhart wants to merge 1 commit intocloudflare:mainfrom
Conversation
Fetch-backed client responses were leaving IncomingMessage.rawHeaders empty, which breaks Node.js compatibility for response listeners and libraries like node-fetch. Also add coverage for duplicate Set-Cookie and synthetic 400 responses.
jasnell
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetch-backed client responses were leaving IncomingMessage.rawHeaders empty, which breaks Node.js compatibility for response listeners and libraries like node-fetch. Also add coverage for duplicate Set-Cookie and synthetic 400 responses.
QUESTION: the behaviour for cookie headers currently differs depending on the
http_headers_getsetcookieflag as fetch() does. But should it? If we want to force behaviour to match Node.js exactly, then we'd need a deeper change here like a lower-level API from fetch/C++ that exposes raw response header pairs before display normalization. For example: