[build] Improve test parallelism through custom resource for socket tests#6699
Open
[build] Improve test parallelism through custom resource for socket tests#6699
Conversation
…ests So far these tests were all running at the end one at a time, now we can run one of them at a time alongside other tests. This should make CI slightly faster.
Contributor
|
The diff confirms all four test changes are straightforward This is a clean, well-motivated change. The approach is correct:
There are no logic bugs, security issues, backward compat violations, or correctness problems. LGTM |
npaun
approved these changes
Apr 30, 2026
Member
npaun
left a comment
There was a problem hiding this comment.
Really cool trick. How did you come up with it?
Contributor
Author
Reading the bazel command line reference and release notes – I think this has been supported since Bazel 7, I just never figured out the right syntax for it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far these tests were all running sequentially after all other tests, now we can run one of them at a time alongside other tests. This should make CI slightly faster.
Reviewers: This will require a downstream change so that the downstream build knows to limit the resource. It will also unlock some exciting optimizations there, stay tuned.
I have confirmed locally that this works as intended.