Skip to content

[build] Improve test parallelism through custom resource for socket tests#6699

Open
fhanau wants to merge 1 commit intomainfrom
felix/parallelism-9000
Open

[build] Improve test parallelism through custom resource for socket tests#6699
fhanau wants to merge 1 commit intomainfrom
felix/parallelism-9000

Conversation

@fhanau
Copy link
Copy Markdown
Contributor

@fhanau fhanau commented Apr 29, 2026

So far these tests were all running sequentially after all other tests, now we can run one of them at a time alongside other tests. This should make CI slightly faster.

Reviewers: This will require a downstream change so that the downstream build knows to limit the resource. It will also unlock some exciting optimizations there, stay tuned.

I have confirmed locally that this works as intended.

…ests

So far these tests were all running at the end one at a time, now we can run
one of them at a time alongside other tests. This should make CI slightly
faster.
@fhanau fhanau requested review from erikcorry, mikea and npaun April 29, 2026 21:48
@fhanau fhanau requested review from a team as code owners April 29, 2026 21:48
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 29, 2026

The diff confirms all four test changes are straightforward exclusive -> resources:socket:1 replacements. The tail-worker-test at line 76 already had exclusive (it was one of the four).

This is a clean, well-motivated change. The approach is correct:

  • Custom Bazel resources (--local_resources=socket=1 + resources:socket:1 tag) provide mutual exclusion among socket-using tests while allowing non-socket tests to run in parallel.
  • All four previously-exclusive tests are converted.
  • No remaining exclusive tags exist in the source tree.
  • The comment on the first occurrence clearly explains the rationale.
  • The PR description notes the downstream dependency, which is appropriate.

There are no logic bugs, security issues, backward compat violations, or correctness problems.

LGTM

github run

Copy link
Copy Markdown
Member

@npaun npaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool trick. How did you come up with it?

@fhanau
Copy link
Copy Markdown
Contributor Author

fhanau commented Apr 30, 2026

Really cool trick. How did you come up with it?

Reading the bazel command line reference and release notes – I think this has been supported since Bazel 7, I just never figured out the right syntax for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants