Streams cleanups, migrate from jsg::BufferSource/jsg::Value/v8::Local to jsg::Js* types#6691
Open
Streams cleanups, migrate from jsg::BufferSource/jsg::Value/v8::Local to jsg::Js* types#6691
Conversation
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
jasnell
changed the title
The jsg::BufferSource will be fully replaced by the the JsArrayBuffer/JsSharedArrayBuffer/JsBufferSource/JsUint8Array APIs. Expand the capabilities of these to support the needs of jsg::BufferSource uses.
jasnell
force-pushed
the
jasnell/streams-updates-jsvalues
branch
from
c6536aa to
62be869
Compare
jasnell
force-pushed
the
jasnell/streams-updates-jsvalues
branch
from
62be869 to
530ed1c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as low quality.
This comment was marked as low quality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jsg::BufferSource will be fully replaced by the the
JsArrayBuffer/JsSharedArrayBuffer/JsBufferSource/JsUint8Array
APIs.
Most of this update is mechanical, replacing jsg::BufferSource/jsg::Value/jsg::V8Ref uses with jsg::Js* types. There are a couple small fixes and improvements along the way.
It's difficult to split this up into smaller Prs so I split up commits a bit. The last commit is larger simply because of how interconnected much of this is.