Conversation
| CERT_PATH="/var/vcap/jobs/opensearch/config/ssl/opensearch-admin.crt" | ||
| KEY_PATH="/var/vcap/jobs/opensearch/config/ssl/opensearch-admin.key" | ||
| CA_PATH="/var/vcap/jobs/opensearch/config/ssl/opensearch.ca" |
There was a problem hiding this comment.
What do you think about making these three variables something that you have to set on the command line before running this script? I have some hesitation about hardcoding these paths into this script, but at the same time I can't think of a very compelling reason why.
|
We need a way or a procedure stating to clean up the document on the vm |
I think this script needs to store them in the /var/vcap/store. that way if its forgotten we aren't putting a manager in danger |
| CERT_PATH="/var/vcap/jobs/opensearch/config/ssl/opensearch-admin.crt" | ||
| KEY_PATH="/var/vcap/jobs/opensearch/config/ssl/opensearch-admin.key" | ||
| CA_PATH="/var/vcap/jobs/opensearch/config/ssl/opensearch.ca" | ||
| OUTPUT_FILE="logs_export.csv" |
There was a problem hiding this comment.
Please change this to be somewhere under /var/vcap/store as currently this script dumps the CSV file under /home/vcap which is the root OS disk and could cause the VM to crash if root runs out of disk
4 participants
Changes proposed in this pull request:
security considerations
uses TLS, improvement.