browserify: Can't walk dependency graph

[jkroepke]

Ref: browserify/browserify#1986

Hi,

today I tried to bump all our node dependencies to latest. After that, our browserify build has stop working:

npx browserify -e src/index.js -o dist/lib.js
Error: Can't walk dependency graph: ENOENT: no such file or directory, lstat '/Users/jkr/Downloads/s/process'
    required by /Users/jkr/Downloads/s/node_modules/node-jose/lib/index.js
npm ERR! code 1
npm ERR! path /Users/jkr/Downloads/s
npm ERR! command failed
npm ERR! command sh -c browserify -e src/index.js -o dist/lib.js

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/jkr/.npm/_logs/2020-11-05T19_08_29_056Z-debug.log

The error does not appear with node-jose 1.1.3 and browserify 16.5.0 but using node-jose 2.0.0 and browserify 17.0.0 the error appears now.

How to reproduce:

1. Run npm install -S node-jose
2. Create a file with content:const jose = require('node-jose')
3. Run npx browserify -e index.js -o lib.js --node or npx browserify index.js > lib.js

The --node option does not change anything.

This error is may related to the PR #284 which introduce an own process shim.

[dstaudt]

Some observations:

• Attempting to browserify @webex:^1.157.0 into a browser app fails with the Can't walk dependency graph error mentioned - using browerify cli 17.0.0
• Bundling succeeds using browserify 16.5.1
• Bundling succeeds after reverting https://github.com/cisco/node-jose/pull/284/files#diff-92bbac9a308cd5fcf9db165841f2d90ce981baddcb2b1e26cfff170929af3bd1
• Bundling succeeds after modifying node-js/lib/index.js by adding a slash to "process": require("process/")
  So it appears Add better react and react-native compatibility #284 is causing browserify bundling to fail.
  Discussion at Browserify here suggests that require("process/") would be the correct formulation.