Packaging of the pyIGRF library#3
Open
galactics wants to merge 4 commits into
Open
Conversation
rename test file to comply with pytest matching pattern disable numpy warning on casting to np.int and np.float adapt tests to package
Owner
|
Thanks for the efforts. We are going to try to make a more 'official' IAGA version of the IGRF for Python users and I'll have a look at your changes to guide me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I modified the organization of your files, in order to make them easily packagable and installable via pip.
This way it is simpler to integrate your functions into other's projects.
I also made a black pass, to normalize the format of the code (indent, double quotes, etc.), but this is totally optional.
I didn't include it in my pull request, but I suggest to change the name of the library for PyPI integration. Another library claimed the name pyIGRF, and I don't think it can be overruled. A publication to PyPI would also advance the chances of others using your library.