Use setuptools-scm v7+ for building the dists#628
Merged
Conversation
webknjaz
requested changes
May 9, 2023
webknjaz
left a comment
webknjaz
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! Please, follow the instructions outlined in sphinx-contrib/sphinxcontrib-towncrier#80 (comment) to make said dependency conditional.
Also, make sure to fix the commit message so that it contains useful details and doesn't cause linting violations like this one: https://github.com/cherrypy/cheroot/actions/runs/4927684940?pr=628#summary-13347875183
serhii73
force-pushed
the
rm-setuptools_scm_git_archive
branch
from
May 14, 2023 13:05
a6baadb to
905bd59
Compare
webknjaz
reviewed
May 14, 2023
serhii73
force-pushed
the
rm-setuptools_scm_git_archive
branch
2 times, most recently
from
May 15, 2023 19:46
d84c424 to
45aa5d0
Compare
serhii73
changed the title
webknjaz
reviewed
May 15, 2023
webknjaz
reviewed
May 15, 2023
serhii73
force-pushed
the
rm-setuptools_scm_git_archive
branch
7 times, most recently
from
May 17, 2023 17:41
23446ac to
5d05b3a
Compare
webknjaz
reviewed
May 17, 2023
webknjaz
reviewed
May 17, 2023
webknjaz
reviewed
May 17, 2023
webknjaz
reviewed
May 17, 2023
webknjaz
reviewed
May 17, 2023
webknjaz
reviewed
May 17, 2023
webknjaz
reviewed
May 22, 2023
serhii73
force-pushed
the
rm-setuptools_scm_git_archive
branch
from
May 28, 2023 17:59
5d05b3a to
b4ea4f2
Compare
serhii73
force-pushed
the
rm-setuptools_scm_git_archive
branch
from
June 6, 2023 15:35
b4ea4f2 to
4bd9e28
Compare
webknjaz
requested changes
Jun 6, 2023
webknjaz
left a comment
webknjaz
left a comment
Member
There was a problem hiding this comment.
There's some things to fix still.
serhii73
force-pushed
the
rm-setuptools_scm_git_archive
branch
2 times, most recently
from
June 7, 2023 13:25
d382570 to
c26b0e7
Compare
webknjaz
reviewed
Jun 7, 2023
serhii73
changed the title
webknjaz
reviewed
Jun 7, 2023
webknjaz
changed the title
setuptools-scm v7+ for building the dists
serhii73
force-pushed
the
rm-setuptools_scm_git_archive
branch
from
June 8, 2023 14:08
2381966 to
36ab389
Compare
Since version 7, setuptools-scm has native support for git archive, so the setuptools-scm-git-archive project is obsolete and this patch removes it from the build dependencies. Close cherrypy#515
serhii73
force-pushed
the
rm-setuptools_scm_git_archive
branch
from
June 8, 2023 14:10
36ab389 to
f0c51af
Compare
webknjaz
approved these changes
Jun 8, 2023
webknjaz
added a commit
that referenced
this pull request
Apr 14, 2024
webknjaz
added a commit
to webknjaz/cheroot
that referenced
this pull request
Apr 17, 2024
This reverts commit 03926f3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since version 7,
setuptools-scmhas native support for git archive, so thesetuptools-scm-git-archiveproject is obsolete and this patch removes it from the build dependencies. Close #515This change is