Skip to content

Conversation

@Dgiordano33
Copy link
Collaborator

Affected Components

  • Content & Marketing
  • Pricing
  • Test
  • Docs
  • Learn
  • Other

Notes for the Reviewer

New Dependency Submission

Screenshots

Copy link
Contributor

@sujaya-sys sujaya-sys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guolau I don't really have context on this change so mainly looked for wording inconsistencies. Hope that helps - feel free to disregard anything that doesn't make sense :)

@@ -1,3 +1,4 @@
---
openapi: get /v1/accounts/{accountId}
title: Get specific account details
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Get specific account details
title: Get details for a specific account

@@ -1,3 +1,4 @@
---
openapi: get /v1/accounts/me
title: Get current account details
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Get current account details
title: Get details for the current account

@@ -1,3 +1,4 @@
---
openapi: get /v1/accounts
title: Get all account details
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Get all account details
title: Get details for all accounts

@@ -1,3 +1,4 @@
---
openapi: post /v1/client-certificates
title: Create new client certificate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Create new client certificate
title: Create a client certificate

@@ -1,3 +1,4 @@
---
openapi: get /v1/analytics/api-checks/{id}
title: Get API Check analytics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Get API Check analytics
title: Get API check analytics

@@ -1,3 +1,4 @@
---
openapi: get /v1/checks/heartbeats/{checkId}/events/{id}
title: List a specific heartbeat event
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: List a specific heartbeat event
title: List a specific event for a heartbeat monitor

@@ -1,3 +1,4 @@
---
openapi: get /v1/checks/heartbeats/{checkId}/availability
title: Get heartbeat availability
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Get heartbeat availability
title: Get heartbeat monitor availability

@@ -1,3 +1,4 @@
---
openapi: put /v1/checks/heartbeat/{id}
title: Update a heartbeat check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Update a heartbeat check
title: Update a heartbeat monitor

@@ -1,3 +1,4 @@
---
openapi: delete /v1/client-certificates/{id}
title: Delete existing client certificate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Delete existing client certificate
title: Delete a client certificate


#### Broken Navigation Links (in docs.json but no MDX file)

| Missing File |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing context on the purpose of this doc, but why are we documenting issues, missing files, open questions, inconsistencies etc here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants