Added index.d.ts for tsx(typescript)#120
Merged
Merged
Conversation
Hermanya
approved these changes
Jun 13, 2019
Hermanya
left a comment
Hermanya
left a comment
Contributor
There was a problem hiding this comment.
This is a good start. There is certainly some room for improvement:
- better inheritance (AbstractChart should be a React.Component, and other charts should extend AbstractChart)
- there is surely a better way to type
styleobjects - better types for callbacks (not just
Function) - type
chartConfig - type
data- this is the most challenging one
Thank you @hirasaki1985 for getting the ball rolling 👍
Contributor
|
now available in v3 |
Contributor
Author
|
thank you for reviewing and approving. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make each chart interfaces.
I have confirmed that each sample in README.md works in my local environment on tsx file.