feat: integrate utils/cert, remove local replace#45
Merged
Conversation
Use published utils/cert and utils/mitmproxy instead of local replace directives. utils/cert provides atomic certificate generation primitives (NewTemplate, SelfSign/SignWith, Fingerprint, TLS config builder, etc.) that mitmproxy now uses for CA creation and DummyCert key-reuse. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Round 1 — panic/crash fixes: - proton: default to "." when -e used without -i, prevent inputs[0] panic - proton: return ctx.Err() in WalkDir to prevent goroutine blocking on jobCh - proton: log WalkDir errors instead of discarding - proton: fix truncate to cut on rune boundaries, not bytes - mitm: remove auto-Clear() in start() that silently destroyed prior captures - mitm: matchStatus returns false for unrecognized patterns instead of true - mitm: reset seq counter in FlowStore.Clear() - mitm: remove dead configureUpstream function and unused imports - build.sh: fix tavily_keys reading from wrong YAML section (websearch→search) - config_test: update stale error message referencing old config.yaml filename - util: handle negative numbers in FormatNumber to prevent infinite recursion Round 2 — code quality improvements: - agent: track ModeIndependent fire goroutines with WaitGroup, wait on Stop/Remove - proton: replace seen map with sync.Map for structural thread safety - agent: allow MaxRetries=0 to mean no retries (change sentinel from ==0 to <0) - evaluator: replace time.Sleep with ctx-aware select in retry loop - loop_tool: support quoted cron expressions in tryCronPrefix - context_window: add gpt-4-1 (128K) and gpt-4-0 (8K) to fix prefix mismatches - tui: replace sync.Once markdown renderer with width-aware cache for resize - web: decouple confirmed status from critical priority in itemToPriority Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… console.go - Type Deps.Logger as telemetry.Logger instead of any for compile-time safety - Extract toolargs.Base with shared Logger/Proxy/WorkDir fields and methods, embed in all 7 scanner tool Commands to eliminate repeated boilerplate - Create per-tool register.go for neutron/spray/zombie/gogo, simplify the central register_command.go to only handle the composite scan command - Split console.go (1331→848 lines) into keybindings.go and banner.go Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add MITM traffic capture section to v0.2.7 changelog - Fix 3 errcheck lint issues in mitm.go (Shutdown return, type assertions) - Widen SSH banner test timeouts to prevent flaky failures under load - Update README/README_CN taglines Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
utils/certandutils/mitmproxyinstead of localreplacedirectivesutils/certprovides atomic certificate primitives (NewTemplate, SelfSign/SignWith, TLS config builder, Fingerprint, etc.)NewTemplate+SignWithatoms for key-reuse patternTestMITMCapture_ServerFirst_Fallback(server-probe byte consumption)Changes
go.mod: remove../utils/certand../utils/mitmproxylocal replace, use publishedv0.0.0-20260624182357-8d5cad72d8f2mitm_bench_test.go: tolerate partial SSH banner in server-first testTest plan
go test ./pkg/tools/proxy/...— 33/33 passgo build ./...— compiles cleango vet ./...— no warnings🤖 Generated with Claude Code