Conversation
auvipy
left a comment
There was a problem hiding this comment.
I'm not in favor of semvar based versioning and very short term new semvar based release version like celery 6/7 etc. rather it is practical to add incremental 5.1, 5.2, 5.3 [django style versioning] and less breaking changes. we can add async based task on celery 5.1 with making the dependencies it uses making them async/await first.
|
A couple of thoughts:
|
|
Check the reasoning of not using semvar https://www.openapis.org/blog/2020/06/18/openapi-3-1-0-rc0-its-here |
I completely agree. Since each of the described versions is going to break at least one thing, I think we should communicate somehow.
What do you mean by "old-style tasks"? |
How do you expect to add async tasks if it requires a lot of changes in the code? |
Pretty much this module: https://github.com/celery/celery/blob/v5.0.0rc1/celery/task/ In general what I'm attempting to say is that Celery has a bunch of deprecated stuff. Let's get rid of it to simplify the code base. |
Oh! I wasn't aware it's still there. |
| - :new-feature:`Worker is now completely asynchronous.` | ||
| - :new-feature:`Users can now define and execute asynchronous tasks.` | ||
| - :new-feature:`Execution Platform` | ||
| - :new-feature:`Asynchronous AMQP 0.9.1 client.` |
There was a problem hiding this comment.
it would be cool if we can add amqp-1.0 eperiemental support as well
| Breaking Changes | ||
| ~~~~~~~~~~~~~~~~ | ||
|
|
||
| - :breaking-change:`Drop support for the prefork workers pool.` |
There was a problem hiding this comment.
can we add deprecation warning for this worker pools? in celery 5.1/.5.2
There was a problem hiding this comment.
No. People complained about us dropping features in minor releases.
We should stick to SemVer even if it is less flexible.
| - :new-feature:`Worker is now completely asynchronous.` | ||
| - :new-feature:`Users can now define and execute asynchronous tasks.` | ||
| - :new-feature:`Execution Platform` | ||
| - :new-feature:`Asynchronous AMQP 0.9.1 client.` |
| :CEP: XXXX | ||
| :Author: Omer Katz | ||
| :Implementation Team: Omer Katz | ||
| :Shepherd: Omer Katz |
There was a problem hiding this comment.
this could be celery core team+technical board
There was a problem hiding this comment.
I assigned myself because at the time we didn't have anyone else active on this repository.
We'll decide who shepherds this soon.
This CEP details our roadmap for the next three major versions.
We will update it occasionally whenever we intend to release a new majpr version or if we decided to reschedule a feature or a breaking change to an earlier or a later release.