Code review - small suggested changes#17
Merged
Conversation
added 2 commits
August 25, 2023 16:02
… to instructions in app.R, toggle comments in app.R to read toy_locs, add toy_locs, add instructions for running locally and link to from README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Code review
title: Pull Request
labels: 'pull request'
assignees: '@KristinaRiemer'
Code review notes
I've gone over the app and the code that runs the app (and left the no-longer-used scripts in
analysis-scriptsalone). This PR includes review notes (review-notes.md) and a couple of small suggested changes to (1) the user-facing in-app documentation and (2) the files in the repo to allow the app to run locally without sensitive location data available.As I was reading through the app code, I added comments and moved some chunks around so that the code underlying different sections of the app is grouped together. That makes no changes to functionality, but, because moving code around creates really big diffs that obscure smaller changes, I'm putting those changes in a separate branch.