Skip to content

Add support for filter, log and risk api - #98

Merged
sebastiansimson merged 5 commits into
feature/generic-request-apifrom
feature/add-support-filter-log-risk-api
Jun 3, 2021
Merged

Add support for filter, log and risk api#98
sebastiansimson merged 5 commits into
feature/generic-request-apifrom
feature/add-support-filter-log-risk-api

Conversation

@sebastiansimson

Copy link
Copy Markdown
Contributor

No description provided.

@sebastiansimson
sebastiansimson requested a review from wallin May 27, 2021 10:18
@sebastiansimson
sebastiansimson changed the base branch from master to feature/generic-request-api May 28, 2021 08:11
@bartes
bartes self-requested a review June 2, 2021 17:47
}

@Override
public CastleResponse log(ImmutableMap<String, Object> payload) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess log should work same as track (without the response)

@sebastiansimson
sebastiansimson force-pushed the feature/generic-request-api branch from 838800d to 7c8d235 Compare June 3, 2021 08:58
@sebastiansimson
sebastiansimson force-pushed the feature/add-support-filter-log-risk-api branch from 267d6b7 to af3663f Compare June 3, 2021 09:08

@bartes bartes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@sebastiansimson
sebastiansimson merged commit 8f0b831 into feature/generic-request-api Jun 3, 2021
sebastiansimson added a commit that referenced this pull request Jun 3, 2021
* Add generic request implementation

* Update path param name

* Add test for generic api requests

* Move api paths

* Add payload keys

* Rename url param to path

* Use constant for http methods

* Return CastleResponse instead of JsonElement for generic api methods

* Add support for filter, log and risk api (#98)

* Add filter, log and risk api

* Add examples

* Add context and user id keys

* Update method doc param to payload

* Add exceptions to examples in readme
@sebastiansimson
sebastiansimson deleted the feature/add-support-filter-log-risk-api branch June 3, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants