Skip to content

Additional CastleHeaders for more convenient initialization - #82

Merged
marysieek merged 1 commit into
castle:masterfrom
brycematheson1234:bryce-castleheaders
Oct 13, 2020
Merged

Additional CastleHeaders for more convenient initialization#82
marysieek merged 1 commit into
castle:masterfrom
brycematheson1234:bryce-castleheaders

Conversation

@brycematheson1234

@brycematheson1234 brycematheson1234 commented Oct 9, 2020

Copy link
Copy Markdown
Contributor

IIUC if you have List<CastleHeader> and you want to transform this into CastleHeaders you must do:

List<CastleHeader> castleHeaderList = createListSomehow(...)
CastlehHeaders castleHeaders = new CastleHeaders()
castleHeaders.set(castleHeaderList)

It would be more convenient to be able to do:

List<CastleHeader> castleHeaderList = createListSomehow(...)
CastlehHeaders castleHeaders = new CastleHeaders(castleHeaderList)

@marysieek
marysieek self-requested a review October 13, 2020 09:27
@marysieek
marysieek merged commit 7b2a13f into castle:master Oct 13, 2020
@marysieek

marysieek commented Oct 13, 2020

Copy link
Copy Markdown

@brycematheson1234 thank you for the contribution! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@marysieek marysieek marysieek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brycematheson1234 @marysieek