Single nic support#190
Merged
bo-quan merged 7 commits intoSep 7, 2018
Merged
Conversation
bo-quan
suggested changes
Aug 31, 2018
Contributor
bo-quan
left a comment
bo-quan
left a comment
There was a problem hiding this comment.
See review comments related to formatting; in addition, could we include documentation changes in the same PR?
| ip = host.get("ip") | ||
| primary_interface = host.get("primary_interface") | ||
| target_interface = host.get("target_interface") | ||
| node_type= host.get("node_type") |
| 'viface_post_play.yaml') | ||
| ansible_command = "ansible-playbook " + post_pb \ | ||
| + " --extra-vars=\'{\"target\": \"" \ | ||
| + ip + "\",\"node_type\":\"" +node_type+"\",\"interface\": \"" + primary_interface + "\"}\'" |
Contributor
There was a problem hiding this comment.
have blank before and after "+" (i.e. "... + ..."). Also this line is too long, make it two lines.
| ip = host.get("ip") | ||
| primary_interface = host.get("primary_interface") | ||
| target_interface = host.get("target_interface") | ||
| node_type=host.get("node_type") |
| 'viface_clean_play.yaml') | ||
| ansible_command = "ansible-playbook " + clean_pb \ | ||
| + " --extra-vars=\'{\"target\": \"" \ | ||
| + ip +"\",\"node_type\":\"" +node_type+"\",\"interface\": \"" + primary_interface + "\"}\'" |
bo-quan
suggested changes
Sep 4, 2018
Contributor
bo-quan
left a comment
bo-quan
left a comment
There was a problem hiding this comment.
A few more changes needed
|
|
||
| ### 3.4 var.yaml (Single NIC settings) | ||
|
|
||
| Configuration file used by SNAPS-OpenStack for single NIC deployemnt. |
|
|
||
| #### Step 3 | ||
|
|
||
| Install fresh openstack using physical interface and veth0 as management and data interfaces respectively. (Please Refer 4.1) |
| ``` | ||
| #### 5.3.2 Single NIC Cleanup | ||
|
|
||
| Before cleaning the opesntack setup user needs to clean the single NIC configurations. |
Contributor
There was a problem hiding this comment.
"openstack"
"clean up" instead of "clean"
| ansible_command = "ansible-playbook " + post_pb \ | ||
| + " --extra-vars=\'{\"target\": \"" \ | ||
| + ip + "\",\"node_type\":\"" + node_type \ | ||
| +"\",\"interface\": \"" + primary_interface \ |
Contributor
There was a problem hiding this comment.
add a space after the first +
| 'viface_clean_play.yaml') | ||
| ansible_command = "ansible-playbook " + clean_pb \ | ||
| + " --extra-vars=\'{\"target\": \"" \ | ||
| + ip +"\",\"node_type\":\"" + node_type \ |
Contributor
There was a problem hiding this comment.
add a space after the 2nd +
| ansible_command = "ansible-playbook " + clean_pb \ | ||
| + " --extra-vars=\'{\"target\": \"" \ | ||
| + ip +"\",\"node_type\":\"" + node_type \ | ||
| +"\",\"interface\": \"" + primary_interface \ |
Contributor
There was a problem hiding this comment.
add a space after the first +
| ip: "" | ||
| primary_interface: "" | ||
| target_interface: "veth1" | ||
| node_type: "compute" |
Contributor
There was a problem hiding this comment.
Move the node_type line before primary_interface to be consistent with the above block, i.e.,
...
node_type: "compute"
primary_interface: ""
...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support for single nic deployment in queens
Do you have any concerns with this PR?
No
How can the reviewer verify this PR?
by deploying Openstack using single nic
Any background context you want to provide?
NA
Screenshots or logs (if appropriate)
NA
Questions:
Add support for single NIC install #128
YES
NO
NO
YES