Remove dependency on std for async feature#1591
Merged
alexcrichton merged 6 commits intobytecodealliance:mainfrom Apr 16, 2026
Merged
Remove dependency on std for async feature#1591alexcrichton merged 6 commits intobytecodealliance:mainfrom
std for async feature#1591alexcrichton merged 6 commits intobytecodealliance:mainfrom
Conversation
This commit adds `no_std` support for the `async` feature of the `wit-bindgen` crate, notably enabling this to be used as part of the standard library for wasip3.
dicej
approved these changes
Apr 16, 2026
| } | ||
| assert_eq!(Arc::weak_count(&self), 0); | ||
|
|
||
| self.in_use.store(false, Release); |
Collaborator
There was a problem hiding this comment.
Should we use RAII for this (or the with pattern you used for WakerState)? I get a little nervous about someone later adding an early return above and not noticing this.
Member
Author
There was a problem hiding this comment.
Seems reasonable yeah 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds
no_stdsupport for theasyncfeature of thewit-bindgencrate, notably enabling this to be used as part of the standard library for wasip3.