rename callbacks and update functionality#241
Merged
richardelms merged 13 commits intointegration/uplift-2025from Nov 24, 2025
Merged
rename callbacks and update functionality#241richardelms merged 13 commits intointegration/uplift-2025from
richardelms merged 13 commits intointegration/uplift-2025from
Conversation
lemnik
reviewed
Nov 14, 2025
Contributor
lemnik
left a comment
lemnik
left a comment
There was a problem hiding this comment.
I think it's worth going over the test callbacks and replacing the old anonymous inner class syntax new Callback() { with lambdas. Maybe in a future PR?
richardelms
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
beforeNotify->onErrorandbeforeSendSession->onSessionMake callbacks return a bool so that sessions and events can be vetoed