Skip to content

rename ignoreClasses to discardClasses#240

Merged
richardelms merged 2 commits intointegration/uplift-2025from
ignoreClassesRenameToDiscardClasses
Nov 13, 2025
Merged

rename ignoreClasses to discardClasses#240
richardelms merged 2 commits intointegration/uplift-2025from
ignoreClassesRenameToDiscardClasses

Conversation

@richardelms
Copy link
Contributor

@richardelms richardelms commented Nov 13, 2025

rename ignoreClasses to discardClasses

Refactoring: Terminology Change from "Ignore" to "Discard"

  • Renamed all references of ignoreClasses to discardClasses in the main configuration (Configuration.java), the Bugsnag client (Bugsnag.java), and the appender (BugsnagAppender.java). This includes method names, variable names, and internal logic. [1] [2] [3]
  • Updated the logic that determines whether an exception class should be reported, now checking discardClasses instead of ignoreClasses.
  • Updated all related logging messages and documentation comments to use "discard" terminology. [1] [2]

Backward Compatibility

  • Added deprecated methods (setIgnoredClass) in BugsnagAppender.java that delegate to the new setDiscardClass methods, ensuring existing integrations do not break.

@richardelms richardelms changed the base branch from next to integration/uplift-2025 November 13, 2025 14:06
@richardelms richardelms self-assigned this Nov 13, 2025
@richardelms richardelms requested a review from lemnik November 13, 2025 14:27
@richardelms richardelms marked this pull request as ready for review November 13, 2025 14:27
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardelms richardelms changed the title Ignore classes rename to discard classes rename ignoreClasses to discardClasses Nov 13, 2025
@richardelms richardelms merged commit 4de3d6a into integration/uplift-2025 Nov 13, 2025
1 check passed
@richardelms richardelms deleted the ignoreClassesRenameToDiscardClasses branch November 13, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants