Safari webtest fixes#412
Open
jscheidtmann wants to merge 11 commits intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch fixes Safari web tests, by
honoring "long-left" from marking menu, and moving to top level menu
adjusting timing
passing the redirect url on login in a more Safari-friendly way.
Using IDs at a few places instead of label texts as these are more stable.
Run against physical PiFinder unit from Safari and Chrome
Failures are transient and a rerun with
--last-failuresshows no failures.(I believe it does not make sense to sink more development time in ironing out the timing issues that remain.)
This also fixes two minor issues we found: