Skip to content

feat(BRE2-756): brev shell external node support#310

Merged
patelspratik merged 1 commit intomainfrom
BRE2-756-shell
Mar 6, 2026
Merged

feat(BRE2-756): brev shell external node support#310
patelspratik merged 1 commit intomainfrom
BRE2-756-shell

Conversation

@patelspratik
Copy link
Contributor

@patelspratik patelspratik commented Mar 4, 2026

brev shell, copy, port-forward, open, and refresh external node support

@patelspratik patelspratik marked this pull request as ready for review March 5, 2026 01:42
@patelspratik patelspratik requested a review from a team as a code owner March 5, 2026 01:42
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 27.11864% with 215 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.86%. Comparing base (88dc335) to head (9805fb9).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/portforward/portforward.go 19.64% 45 Missing ⚠️
pkg/cmd/util/externalnode.go 53.65% 38 Missing ⚠️
pkg/cmd/open/open.go 0.00% 34 Missing ⚠️
pkg/cmd/shell/shell.go 0.00% 34 Missing ⚠️
pkg/cmd/refresh/refresh.go 0.00% 27 Missing ⚠️
pkg/cmd/copy/copy.go 0.00% 25 Missing ⚠️
pkg/ssh/sshconfigurer.go 73.52% 7 Missing and 2 partials ⚠️
pkg/cmd/notebook/notebook.go 0.00% 2 Missing ⚠️
pkg/cmd/register/register.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
+ Coverage   14.77%   15.86%   +1.09%     
==========================================
  Files         127      129       +2     
  Lines       16977    17417     +440     
==========================================
+ Hits         2508     2763     +255     
- Misses      14182    14351     +169     
- Partials      287      303      +16     
Flag Coverage Δ
Linux 15.86% <27.11%> (+1.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@patelspratik patelspratik merged commit cc084c9 into main Mar 6, 2026
11 of 13 checks passed
@patelspratik patelspratik deleted the BRE2-756-shell branch March 6, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants