Add nav class based on depth not parent#249
Merged
florianeckerstorfer merged 1 commit intobraincrafted:developfrom Jun 13, 2014
Merged
Add nav class based on depth not parent#249florianeckerstorfer merged 1 commit intobraincrafted:developfrom
florianeckerstorfer merged 1 commit intobraincrafted:developfrom
Conversation
The nav class should be added when the current depth is 0, meaning when the item is the first to be rendered. The previous way checked if the item had a parent. But this would screw up rendering if the user wanted to render just a subset of the tree.
florianeckerstorfer
pushed a commit
that referenced
this pull request
Jun 13, 2014
Add nav class based on depth not parent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nav class should be added when the current depth is 0, meaning when the item is the first to be rendered. The previous way checked if the item had a parent. But this would screw up rendering if the user wanted to render just a subset of the tree, because that item would always have a parent but should be rendered with the nav class.