Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1922 +/- ##
===========================================
+ Coverage 92.66% 92.79% +0.13%
===========================================
Files 53 53
Lines 10175 10332 +157
===========================================
+ Hits 9429 9588 +159
+ Misses 746 744 -2
Continue to review full report at Codecov.
|
jamesls
left a comment
There was a problem hiding this comment.
I think we should properly support 3.8 this and not just let the misc. warnings propagate. I think we build on https://github.com/boto/botocore/pull/1865/files as part of this change. Only thing I'd change in that PR is moving the try/except into compat.
jamesls
left a comment
There was a problem hiding this comment.
Let's move the imports to compat.py and then we should be good.
botocore/awsrequest.py
Outdated
| urlencode | ||
| from botocore.exceptions import UnseekableStreamError | ||
|
|
||
| try: |
There was a problem hiding this comment.
This is what I was referring to when I mentioned moving the try/except into a compat module. It's repeated 3 times and is a perfect fit for compat.py.
|
@joguSD Updated compat module, should be ready to look at again. Just waiting for travis to pass. |
No description provided.