Replace print with logging in application.py

[diivi]

#1611
Added flake8-print,
referred the flake-8 docs for additional-dependencies - https://flake8.pycqa.org/en/latest/user/using-hooks.html

[real-yfprojects]

We do use print at some places. So try restricting the plugin to production code and add ignore comments to the valid lines.

[diivi]

Okay, so should I ignore the ./package directory and add ignore comments to the print statements used in ./src?

[m3nu]

It's good to clean up those print statements and ensure none are left after debugging. 👍

Just noting that the flake8-print package isn't very popular and looks like the thing that may become unmaintained eventually. There's also supply chain attacks from such less popular packages. So always good to think twice before adding a new dependency. Maybe one of the larger linters adds this feature by then. 🤞

[Hofer-Julian]

It's good to clean up those print statements and ensure none are left after debugging. 👍

Just noting that the flake8-print package isn't very popular and looks like the thing that may become unmaintained eventually. There's also supply chain attacks from such less popular packages. So always good to think twice before adding a new dependency. Maybe one of the larger linters adds this feature by then. 🤞

Agreed, I like ruff as a flake8 and isort alternative.
it also implements this rule: https://beta.ruff.rs/docs/rules/#flake8-print-t20

[real-yfprojects]

Ruff seems to gain popularity already. I don't know how stable it is at the moment but I am open for switching once it is.

[Hofer-Julian]

Ruff seems to gain popularity already. I don't know how stable it is at the moment but I am open for switching once it is.

Fair enough.
Regarding this PR, how about we merge the changes, but don't add the flake8-dependency?

[m3nu]

Regarding this PR, how about we merge the changes, but don't add the flake8-dependency?

If @diivi wants to get this merged, this would be the fastest way.

For extra points, he could add Ruff and make sure it detects the print statement. And we run it in parallel with flake8 for a while. Then remove it, once we are comfortable with it. Better to add a dependency with 10k stars than 100.

[diivi]

Yup, ruff looks like a better alternative, I'll remove flake8-print from this PR and make a new one to add it in ruff.
Should I rename this to chore: replaced print with logging in application.py?

[Hofer-Julian]

For extra points, he could add Ruff and make sure it detects the print statement. And we run it in parallel with flake8 for a while. Then remove it, once we are comfortable with it. Better to add a dependency with 10k stars than 100.

Sounds good to me.

Should I rename this to chore: replaced print with logging in application.py?

If I look at past commits, Replace print with logging in application.py without the chore would be fine

[real-yfprojects]

If I look at past commits, Replace print with logging in application.py without the chore would be fine

Yeah, we will squash any ways.

[real-yfprojects]

There still is one print in production code. But I don't think replacing it would make sense.

vorta/src/vorta/__main__.py

Line 50 in c7c935c

print(f"Vorta {__version__}")

[m3nu]

Looks like a big improvement. 😄