Add exclude flag and skip the devocntainer for bink and bootc-operator #222
Conversation
Introduce the exclude flag to skip certain directories and files. This use clap in order to have a better parsing of the flags, the exclude can be repeated multiple times. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com>
Automatic update of dependencies in Cargo.lock. Signed-off-by: Alice Frosi <afrosi@redhat.com>
Test if the exclude directory and the skip.txt aren't included in the final synchronization- Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com>
For bootc-operator and bink, we aren't use devcontainers, hence we skip the synchronization of these files. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com>
| let current_commit = &args[3]; | ||
|
|
||
| CommonFileSyncer::sync(&infra_path, &target_path, current_commit)?; | ||
| CommonFileSyncer::sync( |
There was a problem hiding this comment.
Not a blocker but this is getting to the point we should probably break these into a struct SyncOpts or whatnot, I think the ergonomics are clearer as opposed to growing the args and needing to keep track of the ordering of parameters.
|
But...they are more likely to make things work if e.g. someone launches in Codespaces for these repos. #100 is tracking actually using devcontainers more in GHA flows, which I think still makes sense. Is it really worth carrying a divergence here? |
Well, we need to test it that's the main reason why we disable it. Right now, we deliver bink as container image but we should try to deploy it with devcontainer. The bootc-operator strongly relay on bink, so once it is on board we can re-enable it. |
|
Filed bootc-dev/bink#95 |
3 participants
For bootc-operator and bink, we don't relay on devcontainer, so we would like to skip the sync of the devcontainer directory