Skip to content

Add include for add_const#157

Merged
neilgroves merged 1 commit intoboostorg:developfrom
cho-m:any_iterator_interface-add_const
Apr 25, 2025
Merged

Add include for add_const#157
neilgroves merged 1 commit intoboostorg:developfrom
cho-m:any_iterator_interface-add_const

Conversation

@cho-m
Copy link
Copy Markdown
Contributor

@cho-m cho-m commented Mar 31, 2025

While testing 1.88.0.beta1 in Homebrew (Homebrew/homebrew-core#217231), I saw a build error for ncmpcpp:

  In file included from ./curses/menu.h:25:
  In file included from /opt/homebrew/include/boost/range/detail/any_iterator.hpp:22:
  /opt/homebrew/include/boost/range/detail/any_iterator_interface.hpp:30:26: error: no template named 'add_const'; did you mean 'std::add_const'?
     30 |                 typename add_const<
        |                          ^

From glance, it looks like Boost add_const is wanted for

Signed-off-by: Michael Cho <michael@michaelcho.dev>
@cho-m cho-m mentioned this pull request Mar 31, 2025
10 tasks
@computerquip-work
Copy link
Copy Markdown

computerquip-work commented Apr 24, 2025

Ran into this as well, seems to prevent compilation entirely with no way to work around (without hacking in an add_const.hpp include just before). Change LGTM, I have to use similar locally.

@neilgroves neilgroves merged commit 1d124e8 into boostorg:develop Apr 25, 2025
fluffykhv added a commit to fluffykhv/freebsd-ports-boost that referenced this pull request Apr 29, 2025
@cho-m cho-m deleted the any_iterator_interface-add_const branch July 25, 2025 23:37
@jwakely
Copy link
Copy Markdown

jwakely commented Jan 12, 2026

This patch was not merged to the release branch, so boost-1.90.0 still has this bug.

@adentinger
Copy link
Copy Markdown

adentinger commented Jan 22, 2026

@jwakely I have the same problem, so I created an issue for it: #163

@doronbehar
Copy link
Copy Markdown

Please boost maintainers, it'd be nice to include this patch in the 1.88 - 1.90 releases.

@jwakely
Copy link
Copy Markdown

jwakely commented Feb 26, 2026

Please boost maintainers, it'd be nice to include this patch in the 1.88 - 1.90 releases.

That's impossible, those releases have already been done (and Boost very rarely does a .1 release like 1.90.1).

But it would be nice if it could get fixed for the next release. It's really silly how often things are fixed on the devel branch and not merged to the (completely separate and unrelated) release branch. The boost branch workflow is error prone and encourages this mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants