Skip to content

fix selected#41

Merged
hofnerb merged 1 commit intomasterfrom
fix_selected
May 2, 2017
Merged

fix selected#41
hofnerb merged 1 commit intomasterfrom
fix_selected

Conversation

@ja-thomas
Copy link
Member

@ja-thomas ja-thomas commented May 2, 2017

This should fix #39 and #40

I'll clean up and doc the code, then we can merge (if everything passes).

The problem was that with the update of mboost, mstop=0 is possible and risk has two more entries, but we have no selected BLs for these, which results in the errors

Also my editor is removing a lot of whitespaces, I'll fix that for the PR. But first let's see if the tests are running.

@ja-thomas
Copy link
Member Author

Error: could not find function "glmboostLSS"
Execution halted

.... lol what

@hofnerb
Copy link
Member

hofnerb commented May 2, 2017

That is very weird!!!

@ja-thomas
Copy link
Member Author

require(gamboostlSS) was missing from the new test

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 33537ac on fix_selected into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 33537ac on fix_selected into ** on master**.

@hofnerb
Copy link
Member

hofnerb commented May 2, 2017

tüdüdü... Freitag abend...

@ja-thomas ja-thomas changed the title fix selected [cleanup required] fix selected May 2, 2017
@ja-thomas
Copy link
Member Author

Should be good now, can be merged if everything is green, imo.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1e606c7 on fix_selected into ** on master**.

@hofnerb
Copy link
Member

hofnerb commented May 2, 2017

what's the reason for using mstop = 20?

@hofnerb hofnerb merged commit 57117da into master May 2, 2017
@hofnerb hofnerb deleted the fix_selected branch May 2, 2017 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

selected.mboostLSS is broken

3 participants