Implement serde_with::SerializeAs and serde_with ::DeserializeAs for ArrayVec#249
Open
kraktus wants to merge 1 commit intobluss:masterfrom
Open
Implement serde_with::SerializeAs and serde_with ::DeserializeAs for ArrayVec#249kraktus wants to merge 1 commit intobluss:masterfrom
serde_with::SerializeAs and serde_with ::DeserializeAs for ArrayVec#249kraktus wants to merge 1 commit intobluss:masterfrom
Conversation
`serde_with` is a widely used crate (24M downloads) to allow custom (de)serialisation.
This commit allow to use Arrayvec as a container in the `serde_with::serde_as` macro.
```rust
#[serde_as]
#[derive(Serialize, Deserialize)]
pub struct Native {
#[serde_as(as = "ArrayVec<DisplayFromStr,128>")]
pub sans: ArrayVec<TypeWithoutSerde, 128>,
}
```
I've it included under the `serde` feature, but it can be on its own feature.
If this is deemed to niche to include, an alternative would be to include it directly in the `serde_with` crate under a feature flag, similar to what is done for other popular library, such as `hashbrown_0_14` or `chrono_0_4`. It has the disadvantage of pinning to one version.
kraktus
changed the title
SerializeAs and DeserializeAs for ArrayVecserde_with::SerializeAs and serde_with ::DeserializeAs for ArrayVec
Author
|
Gentle bump, if I rebase this would there be any chance of being merged? |
Author
|
Gentle bump after two years, worth rebasing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serde_withis a widely used crate (24M downloads) to allow custom (de)serialisation.This commit allow to use Arrayvec as a container in the
serde_with::serde_asmacro.I've it included under the
serdefeature, but it can be on its own feature.If this is deemed to niche to include, an alternative would be to include it directly in the
serde_withcrate under a feature flag, similar to what is done for other popular library, such ashashbrown_0_14orchrono_0_4. It has the disadvantage of pinning to one version.